New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] [xbuild] build_requires from host profile is applied to other build requires #7169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I cannot request changes as it is my PR... )
conans/test/functional/cross_building/build_requires_from_profile_test.py
Show resolved
Hide resolved
…ile_test.py Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
@@ -52,6 +52,5 @@ def test_br_from_profile_host_and_profile_build(self): | |||
t.run("create library.py --profile:host=profile_host --profile:build=profile_build --build *") | |||
self.assertNotIn("br1/version: Applying build-requirement: br2/version", t.out) | |||
self.assertIn("br1/version: Applying build-requirement: br3/version", t.out) | |||
self.assertIn("br2/version: Applying build-requirement: br3/version", t.out) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course this one fails, but we need to write down if this is a known bug we don't want to fix right now or it is a design decision not to apply BRs to BRs when they are defined in profiles.
Changelog: Fix: Packages listed as
build_requires
in recipes that belong to the host context don't add asbuild_requires
those listed in the host profile.Docs: omit
The BR that is declared in the
profile_host
is incorrectly applied to the other build_requires that is declared in thelibrary
recipe.closes #7214